Skip to content

Add MojoExecutionException as cause of SentryCliException #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

lcian
Copy link
Member

@lcian lcian commented Jul 17, 2025

📜 Description

When CLI fails to run, the reason might not be strictly due to CLI itself but due to other failures, such as not having permission to write the file where we attempt to save the output of CLI, as seen in #169 .

To uncover those failures, we now attach the MojoExecutionException as cause of the SentryCliException.

Note that

  • this is a breaking change (but we could also just make a new constructor)
  • it will create new groups in our build tool crash reporting project in Sentry

Tested manually by verifying that the cause and its stack trace are logged upon failure.

@lcian
Copy link
Member Author

lcian commented Jul 17, 2025

We've decided to implement it like this in the first place to avoid capturing user data when reporting the error to our own Sentry project, closing.

@lcian lcian closed this Jul 17, 2025
@lcian lcian deleted the lcian/ref/cli-cause branch July 17, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant