feat: add option to ignore source bundle upload failures

src/main/java/io/sentry/UploadSourceBundleMojo.java

@@ -70,6 +70,9 @@ public class UploadSourceBundleMojo extends AbstractMojo {
   @Parameter(defaultValue = DEFAULT_SKIP_SOURCE_BUNDLE_STRING)
   private boolean skipSourceBundle;
 
+  @Parameter(defaultValue = DEFAULT_IGNORE_SOURCE_BUNDLE_UPLOAD_FAILURE_STRING)
+  private boolean ignoreSourceBundleUploadFailure;
+
   @SuppressWarnings("NullAway")
   @Component
   private @NotNull BuildPluginManager pluginManager;
@@ -257,7 +260,11 @@ private void uploadSourceBundle(
       cliRunner.runSentryCli(String.join(" ", command), true);
     } catch (Throwable t) {
       SentryTelemetryService.getInstance().captureError(t, "uploadSourceBundle");
-      throw t;
+      if (ignoreSourceBundleUploadFailure) {
+        logger.warn("Source bundle upload failed, ignored by configuration");
+      } else {
+        throw t;
+      }
     } finally {
       SentryTelemetryService.getInstance().endTask(span);
     }

src/main/java/io/sentry/config/PluginConfig.java

@@ -12,6 +12,8 @@ public class PluginConfig {
   public static final @NotNull String DEFAULT_SKIP_AUTO_INSTALL_STRING = "false";
   public static final boolean DEFAULT_SKIP_SOURCE_BUNDLE = false;
   public static final @NotNull String DEFAULT_SKIP_SOURCE_BUNDLE_STRING = "false";
+  public static final boolean DEFAULT_IGNORE_SOURCE_BUNDLE_UPLOAD_FAILURE = false;
+  public static final @NotNull String DEFAULT_IGNORE_SOURCE_BUNDLE_UPLOAD_FAILURE_STRING = "false";
   public static final boolean DEFAULT_SKIP_TELEMETRY = false;
   public static final @NotNull String DEFAULT_SKIP_TELEMETRY_STRING = "false";
   public static final boolean DEFAULT_DEBUG_SENTRY_CLI = false;
@@ -28,6 +30,7 @@ public class PluginConfig {
   private boolean skipTelemetry = DEFAULT_SKIP_TELEMETRY;
   private boolean skipReportDependencies = DEFAULT_SKIP_REPORT_DEPENDENCIES;
   private boolean skipSourceBundle = DEFAULT_SKIP_SOURCE_BUNDLE;
+  private boolean ignoreSourceBundleUploadFailure = DEFAULT_IGNORE_SOURCE_BUNDLE_UPLOAD_FAILURE;
   private boolean debugSentryCli = DEFAULT_DEBUG_SENTRY_CLI;
   private boolean debug = DEFAULT_DEBUG;
   private boolean skipValidateSdkDependencyVersions = DEFAULT_SKIP_VALIDATE_SDK_DEPENDENCY_VERSIONS;
@@ -88,6 +91,10 @@ public void setSkipSourceBundle(final boolean skipSourceBundle) {
     this.skipSourceBundle = skipSourceBundle;
   }
 
+  public void setIgnoreSourceBundleUploadFailure(final boolean ignoreSourceBundleUploadFailure) {
+    this.ignoreSourceBundleUploadFailure = ignoreSourceBundleUploadFailure;
+  }
+
   public void setSkipValidateSdkDependencyVersions(
       final boolean skipValidateSdkDependencyVersions) {
     this.skipValidateSdkDependencyVersions = skipValidateSdkDependencyVersions;
@@ -109,6 +116,10 @@ public boolean isSkipSourceBundle() {
     return skipSourceBundle || skip;
   }
 
+  public boolean isIgnoreSourceBundleUploadFailure() {
+    return ignoreSourceBundleUploadFailure;
+  }
+
   public boolean isSkipValidateSdkDependencyVersions() {
     return skipValidateSdkDependencyVersions;
   }

src/test/java/io/sentry/integration/uploadSourceBundle/PomUtils.kt

@@ -3,9 +3,11 @@ package io.sentry.integration.uploadSourceBundle
 fun basePom(
     skipPlugin: Boolean = false,
     skipSourceBundle: Boolean = false,
+    ignoreSourceBundleUploadFailure: Boolean = false,
     sentryCliPath: String? = null,
     extraSourceRoots: List<String> = listOf(),
     extraSourceContextDirs: List<String> = emptyList(),
+    sentryUrl: String? = null,
 ): String {
     val extraSourceRootsXml =
         if (extraSourceRoots.isEmpty()) {
@@ -88,10 +90,12 @@ fun basePom(
                             <debugSentryCli>true</debugSentryCli>
                             <skip>$skipPlugin</skip>
                             <skipSourceBundle>$skipSourceBundle</skipSourceBundle>
+                            <ignoreSourceBundleUploadFailure>$ignoreSourceBundleUploadFailure</ignoreSourceBundleUploadFailure>
                             <skipTelemetry>true</skipTelemetry>
                             <org>sentry-sdks</org>
                             <project>sentry-maven</project>
                             <authToken>\&lt;token\&gt;</authToken>
+                            ${if (sentryUrl.isNullOrBlank()) "" else "<url>$sentryUrl</url>"}
                             ${if (sentryCliPath.isNullOrBlank()) "" else "<sentryCliExecutablePath>$sentryCliPath</sentryCliExecutablePath>"}
                             $extraSourceContextDirsXml
                         </configuration>

src/test/java/io/sentry/integration/uploadSourceBundle/UploadSourceBundleTestIT.kt

@@ -17,6 +17,7 @@ import java.util.Properties
 import kotlin.io.path.Path
 import kotlin.io.path.absolutePathString
 import kotlin.test.assertEquals
+import kotlin.test.assertFailsWith
 import kotlin.test.assertTrue
 
 class UploadSourceBundleTestIT {
@@ -27,17 +28,54 @@ class UploadSourceBundleTestIT {
         baseDir: File,
         skipPlugin: Boolean = false,
         skipSourceBundle: Boolean = false,
+        ignoreSourceBundleUploadFailure: Boolean = false,
         sentryCliPath: String? = null,
         extraSourceRoots: List<String> = listOf(),
         extraSourceContextDirs: List<String> = emptyList(),
+        sentryUrl: String? = null,
     ): String {
-        val pomContent = basePom(skipPlugin, skipSourceBundle, sentryCliPath, extraSourceRoots, extraSourceContextDirs)
+        val pomContent =
+            basePom(
+                skipPlugin,
+                skipSourceBundle,
+                ignoreSourceBundleUploadFailure,
+                sentryCliPath,
+                extraSourceRoots,
+                extraSourceContextDirs,
+                sentryUrl,
+            )
 
         Files.write(Path("${baseDir.absolutePath}/pom.xml"), pomContent.toByteArray(), StandardOpenOption.CREATE)
 
         return baseDir.absolutePath
     }
 
+    @Test
+    fun `does not fail build when upload fails and ignoreSourceBundleUploadFailure is true`() {
+        val baseDir = setupProject()
+        val path = getPOM(baseDir, ignoreSourceBundleUploadFailure = true, sentryUrl = "http://unknown")
+        val verifier = Verifier(path)
+        verifier.isAutoclean = false
+
+        verifier.executeGoal("install")
+        verifier.verifyTextInLog("Source bundle upload failed, ignored by configuration")
+        verifier.resetStreams()
+    }
+
+    @Test
+    fun `fails build when upload fails and ignoreSourceBundleUploadFailure is false`() {
+        val baseDir = setupProject()
+        val path = getPOM(baseDir, sentryUrl = "http://unknown")
+        val verifier = Verifier(path)
+        verifier.isAutoclean = false
+
+        assertFailsWith<VerificationException> {
+            verifier.executeGoal("install")
+        }
+
+        verifier.verifyTextInLog("Could not resolve hostname (Could not resolve host: unknown)")
+    }
+
     @Test
     @Throws(VerificationException::class, IOException::class)
     fun `uploads source bundle`() {
@@ -161,9 +199,7 @@ class UploadSourceBundleTestIT {
         verifier.resetStreams()
     }
 
-    private fun setupEmptyProject(): File {
-        return setupProject(subdirectories = emptyList())
-    }
+    private fun setupEmptyProject(): File = setupProject(subdirectories = emptyList())
 
     private fun setupProject(
         baseDir: String = "base",