Skip to content

Allow passing arbitrary event types to the rate limiter #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stayallive
Copy link
Collaborator

This allows us to re-use the rate limiter in: getsentry/sentry-php-agent#16

Since we already store arbitrary rate-limits anyway it makes sense we can also check for them instead of only the ones we have defined in our event type enum.

With PHP's type juggling this might not be a breaking change unless strict_types is defined. Unsure if we can make this change. Nevermind, we can remove any breaking concern by just doing what I've done in now 👍

@stayallive stayallive requested a review from cleptric May 6, 2025 15:04
@stayallive stayallive self-assigned this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants