Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spotlight): Add info logs when Sentry is enabled #3735

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Nov 5, 2024

This came as user feedback (getsentry/spotlight#543). Intentionally not making this part of Sentry logging as I think if one is enabling Spotlight, they should be seeing this in their logs, regardless of their SENTRY_DEBUG setting, which tends to be noisy.

This came as user feedback (getsentry/spotlight#543). Intentionally not making this part of Sentry logging as I think if one is enabling Spotlight, they should be seeing this in their logs, regardless of their SENTRY_DEBUG setting, which tends to be noisy.
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (e28dcf6) to head (cbdc15f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/spotlight.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3735      +/-   ##
==========================================
+ Coverage   84.33%   84.37%   +0.03%     
==========================================
  Files         136      136              
  Lines       14367    14370       +3     
  Branches     2417     2417              
==========================================
+ Hits        12117    12125       +8     
+ Misses       1497     1495       -2     
+ Partials      753      750       -3     
Files with missing lines Coverage Δ
sentry_sdk/spotlight.py 68.11% <85.71%> (+1.44%) ⬆️

... and 4 files with indirect coverage changes

@BYK BYK merged commit 24e5359 into master Nov 5, 2024
136 checks passed
@BYK BYK deleted the byk/feat/spotlight-log branch November 5, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants