Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spotlight): Inject Spotlight button on Django #3751

Merged
merged 11 commits into from
Nov 12, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Nov 8, 2024

This patch expands the SpotlightMiddleware for Django and injects the Spotlight button to all HTML responses when Spotlight is enabled and running. It requires Spotlight 2.6.0 to work this way.

Ref: getsentry/spotlight#543

This patch expands the `SpotlightMiddleware` for Django and injects the Spotlight button to all HTML responses when Spotlight is enabled and running. It requires Spotlight 2.6.0 to work this way.
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 32 lines in your changes missing coverage. Please review.

Project coverage is 84.29%. Comparing base (d424226) to head (44552a9).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/spotlight.py 44.82% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3751      +/-   ##
==========================================
- Coverage   84.40%   84.29%   -0.12%     
==========================================
  Files         136      136              
  Lines       14379    14418      +39     
  Branches     2422     2429       +7     
==========================================
+ Hits        12137    12154      +17     
- Misses       1491     1514      +23     
+ Partials      751      750       -1     
Files with missing lines Coverage Δ
sentry_sdk/spotlight.py 58.33% <44.82%> (-9.79%) ⬇️

... and 3 files with indirect coverage changes

@BYK BYK requested a review from antonpirker November 8, 2024 13:20
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left some suggestions/questions

sentry_sdk/spotlight.py Outdated Show resolved Hide resolved
sentry_sdk/spotlight.py Outdated Show resolved Hide resolved
sentry_sdk/spotlight.py Outdated Show resolved Hide resolved
sentry_sdk/spotlight.py Show resolved Hide resolved
@BYK BYK requested a review from sentrivana November 11, 2024 22:02
@BYK BYK enabled auto-merge (squash) November 12, 2024 13:15
@BYK BYK merged commit 417be9f into master Nov 12, 2024
135 of 136 checks passed
@BYK BYK deleted the byk/feat/spotlight-middleware-next branch November 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants