-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spotlight): Inject Spotlight button on Django #3751
Conversation
This patch expands the `SpotlightMiddleware` for Django and injects the Spotlight button to all HTML responses when Spotlight is enabled and running. It requires Spotlight 2.6.0 to work this way.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3751 +/- ##
==========================================
- Coverage 84.40% 84.29% -0.12%
==========================================
Files 136 136
Lines 14379 14418 +39
Branches 2422 2429 +7
==========================================
+ Hits 12137 12154 +17
- Misses 1491 1514 +23
+ Partials 751 750 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left some suggestions/questions
Co-authored-by: Ivana Kellyer <[email protected]>
This patch expands the
SpotlightMiddleware
for Django and injects the Spotlight button to all HTML responses when Spotlight is enabled and running. It requires Spotlight 2.6.0 to work this way.Ref: getsentry/spotlight#543