fix(ios): resolve relative SOURCEMAP_FILE against project root in Xcode build script by antonis · Pull Request #5730 · getsentry/sentry-react-native

antonis · 2026-02-26T15:52:15Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Resolves a bug where a user-set relative SOURCEMAP_FILE (e.g. SOURCEMAP_FILE=maps/main.jsbundle.map or SOURCEMAP_FILE=./maps/main.jsbundle.map) would not be found by sentry-cli.

The Xcode build script runs from ios/ (PWD=ios), but the React Native bundle is created relative to the project root. Without this fix, sentry-cli was looking in the wrong directory.

Fix: if SOURCEMAP_FILE is a relative path, it is resolved to an absolute path using the project root (RN_PROJECT_ROOT = PROJECT_DIR/..) before being passed to sentry-cli. A leading ./ is also stripped via bash parameter expansion (${SOURCEMAP_FILE#./}) to produce a clean absolute path.

The default value ($DERIVED_FILE_DIR/main.jsbundle.map) is already absolute and is unaffected.

💡 Motivation and Context

Users setting a relative SOURCEMAP_FILE in their Xcode build phase would silently produce incorrect source map paths, causing upload failures.

Fixes #3889

💚 How did you test it?

Added 4 new unit tests to sentry-xcode-scripts.test.ts covering:

Absolute path is left unchanged
Relative path is resolved against the project root (not ios/)
./-prefixed path is resolved against the project root with ./ stripped
Default (unset) value remains the absolute $DERIVED_FILE_DIR/main.jsbundle.map

All existing tests continue to pass.

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

…de build script When users set SOURCEMAP_FILE to a relative path (e.g. `SOURCEMAP_FILE=maps/main.jsbundle.map`), the value is now resolved against the project root (one level up from `ios/`) rather than against the `ios/` directory where the Xcode build script runs. Without this fix, sentry-cli could not find the source map because the bundle is created relative to the project root. Fixes #3889 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions · 2026-02-26T15:52:37Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

fix(ios): resolve relative SOURCEMAP_FILE against project root in Xcode build script by antonis in #5730

test(metro): Add type tests for SentryExpoConfigOptions.getDefaultConfig by antonis in #5733
chore(deps): bump axios to ^1.13.5 by antonis in #5708
chore(deps): bump on-headers to ^1.1.0 by antonis in #5704
chore(deps): bump dottie from 2.0.6 to 2.0.7 by dependabot in #5731
Cirrus Labs runners for other important workflows (where it makes sense to do so) + Ubuntu update (22.04 -> 24.04) by alwx in #5696
chore(deps): bump diff to ^5.2.2 by antonis in #5705
chore(deps): update Bundler Plugins to v5.1.1 by github-actions in #5700
chore(deps): update JavaScript SDK to v10.40.0 by github-actions in #5715
ci: Cancel in-progress CI jobs when a PR is closed or merged by antonis in #5725

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-02-26T16:34:24Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	488.04 ms	524.74 ms	36.70 ms
Size	43.75 MiB	48.46 MiB	4.71 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ec14be7`+dirty	403.50 ms	411.46 ms	7.96 ms
`e76d0d3`+dirty	404.18 ms	411.53 ms	7.35 ms
`785ffb1`	471.92 ms	460.96 ms	-10.96 ms
`ff5a06a`+dirty	405.97 ms	439.24 ms	33.27 ms
`6416d6c`+dirty	407.30 ms	422.00 ms	14.70 ms
`eec00c2`+dirty	447.08 ms	469.04 ms	21.96 ms
`7480abe`+dirty	411.60 ms	405.81 ms	-5.78 ms
`c08359e`	421.87 ms	445.37 ms	23.50 ms
`64cd15c`	439.02 ms	427.63 ms	-11.39 ms
`af9331b`	449.77 ms	479.20 ms	29.43 ms

App size

Revision	Plain	With Sentry	Diff
`ec14be7`+dirty	17.75 MiB	19.69 MiB	1.94 MiB
`e76d0d3`+dirty	17.75 MiB	19.71 MiB	1.96 MiB
`785ffb1`	17.75 MiB	20.15 MiB	2.41 MiB
`ff5a06a`+dirty	43.75 MiB	48.05 MiB	4.29 MiB
`6416d6c`+dirty	43.75 MiB	48.05 MiB	4.30 MiB
`eec00c2`+dirty	43.75 MiB	48.05 MiB	4.29 MiB
`7480abe`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`c08359e`	17.75 MiB	20.15 MiB	2.41 MiB
`64cd15c`	17.75 MiB	20.15 MiB	2.41 MiB
`af9331b`	17.75 MiB	19.68 MiB	1.94 MiB

github-actions · 2026-02-26T17:48:05Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1219.22 ms	1228.07 ms	8.84 ms
Size	3.38 MiB	4.78 MiB	1.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`80e4616`+dirty	1221.32 ms	1225.64 ms	4.32 ms
`818a608`+dirty	1205.76 ms	1208.00 ms	2.24 ms
`77061ed`+dirty	1233.16 ms	1234.88 ms	1.71 ms
`bef3709`+dirty	1222.07 ms	1220.24 ms	-1.83 ms
`a206511`+dirty	1185.00 ms	1186.35 ms	1.35 ms
`74979ac`+dirty	1210.49 ms	1213.31 ms	2.82 ms
`a2bb688`+dirty	1223.53 ms	1232.90 ms	9.37 ms
`8a868fe`+dirty	1221.50 ms	1230.78 ms	9.28 ms
`d590428`+dirty	1211.77 ms	1220.51 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`77061ed`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-02-26T18:17:53Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	401.25 ms	451.20 ms	49.95 ms
Size	43.94 MiB	49.34 MiB	5.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`785ffb1`+dirty	380.65 ms	451.83 ms	71.18 ms
`59d1977`+dirty	366.15 ms	393.21 ms	27.06 ms
`95aaf8a`+dirty	342.82 ms	393.75 ms	50.93 ms
`5ee3314`+dirty	358.69 ms	394.00 ms	35.31 ms
`b1579bc`+dirty	391.87 ms	456.26 ms	64.39 ms
`4052277`+dirty	369.90 ms	381.16 ms	11.26 ms
`4a17c8f`+dirty	368.54 ms	381.43 ms	12.89 ms
`eb07ba3`+dirty	419.49 ms	482.12 ms	62.63 ms
`cdf7e97`+dirty	389.79 ms	418.13 ms	28.34 ms
`93137d1`+dirty	367.58 ms	434.94 ms	67.36 ms

App size

Revision	Plain	With Sentry	Diff
`785ffb1`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`59d1977`+dirty	43.94 MiB	49.22 MiB	5.29 MiB
`95aaf8a`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`5ee3314`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`b1579bc`+dirty	43.94 MiB	49.27 MiB	5.33 MiB
`4052277`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`4a17c8f`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`eb07ba3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`cdf7e97`+dirty	43.94 MiB	49.22 MiB	5.29 MiB
`93137d1`+dirty	7.15 MiB	8.43 MiB	1.28 MiB

github-actions · 2026-02-26T18:35:47Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1214.41 ms	1216.24 ms	1.83 ms
Size	3.38 MiB	4.78 MiB	1.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms
`80e4616`+dirty	1206.90 ms	1205.94 ms	-0.96 ms
`818a608`+dirty	1218.84 ms	1223.18 ms	4.34 ms
`77061ed`+dirty	1210.77 ms	1218.45 ms	7.68 ms
`bef3709`+dirty	1217.79 ms	1225.33 ms	7.54 ms
`a206511`+dirty	1225.02 ms	1223.74 ms	-1.28 ms
`74979ac`+dirty	1212.33 ms	1212.54 ms	0.21 ms
`a2bb688`+dirty	1244.82 ms	1238.60 ms	-6.22 ms
`8a868fe`+dirty	1206.85 ms	1215.04 ms	8.19 ms
`d590428`+dirty	1221.23 ms	1225.27 ms	4.03 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`77061ed`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

antonis · 2026-02-27T10:16:07Z

@sentry review

antonis · 2026-02-27T10:16:15Z

@claude review

Strip leading ./ via parameter expansion before joining with the project root, so ./maps/main.jsbundle.map resolves to a clean absolute path instead of /project/root/./maps/main.jsbundle.map. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

lucas-zimerman

that's a nice fix! LGTM!

antonis added 2 commits February 26, 2026 16:55

changelog: resolve relative SOURCEMAP_FILE in Xcode build script

f79190d

Merge branch 'main' into antonis/issue-3889

85f8a5f

antonis added the ready-to-merge Triggers the full CI test suite label Feb 26, 2026

antonis and others added 3 commits February 27, 2026 11:30

Merge branch 'main' into antonis/issue-3889

fac6774

Fix typo

6c83813

antonis marked this pull request as ready for review February 27, 2026 10:57

antonis requested review from alwx and lucas-zimerman as code owners February 27, 2026 10:57

lucas-zimerman approved these changes Feb 27, 2026

View reviewed changes

Merge branch 'main' into antonis/issue-3889

4e5d1a5

antonis enabled auto-merge (squash) February 27, 2026 14:01

Merge branch 'main' into antonis/issue-3889

dd46979

antonis merged commit eef7c4c into main Feb 27, 2026
47 of 72 checks passed

antonis deleted the antonis/issue-3889 branch February 27, 2026 15:00

Uh oh!

Conversation

antonis commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

antonis commented Feb 27, 2026

Uh oh!

antonis commented Feb 27, 2026

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

antonis commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 26, 2026 •

edited

Loading