Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plan] Version 6 #1279

Open
st0012 opened this issue Feb 10, 2021 · 8 comments
Open

[Plan] Version 6 #1279

st0012 opened this issue Feb 10, 2021 · 8 comments
Labels
Milestone

Comments

@st0012
Copy link
Collaborator

st0012 commented Feb 10, 2021

  • Drop support of Rails 5.0 & 5.1
  • Drop support of Ruby 2.4
  • Drop some configuration options
    • async - async option will be dropped. #1522
    • linecache - I guess no one is using this. if you do, please let me know your use case
    • exclude_loggers - this only works with sentry_logger breadcrumb logger. given that probably not many people use the logger, there should be even fewer (or no) people use this option.
  • Event#to_hash only returns a string key hash.
    • Currently, Hash-form events have string keys if they're generated from #to_json_compatible. But #to_hash returns a symbol key hash. So it can be confusing to users when dealing with events in callbacks.
  • Remove hub argument from Transaction#finish
  • Advanced Sidekiq reporting control
  • Type signature (maybe)
  • Fix stacktrace trimming Stack Trace Trimming is trimming relevant frames #2018

(feel free to add your feedback/request)

@st0012 st0012 added the wip label Feb 10, 2021
@dlibanori
Copy link

Please, drop faraday. As utility library you shouldn't set any gem your client may be using. Right now I have to "upgrade" my farady to migrate from sentry-raven to sentry-ruby :(

@st0012
Copy link
Collaborator Author

st0012 commented Mar 28, 2021

@dlibanori the version requirement on faraday is to make sure it'll always work with the SDK. you can use sentry-ruby-core to bypass the limitation. but depending on the faraday version you have, it may or may not work.

@st0012 st0012 pinned this issue Mar 28, 2021
@st0012 st0012 added this to the 5.0.0 milestone Aug 1, 2021
@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@st0012 st0012 modified the milestones: 5.0.0, 6.0.0 Jan 7, 2022
@st0012 st0012 changed the title [Plan] Version 5 [Plan] Version 6 Jan 20, 2022
@AlexWayfer
Copy link
Contributor

Update Faraday to version 2?

@st0012
Copy link
Collaborator Author

st0012 commented Sep 2, 2022

@AlexWayfer Faraday is no longer the SDK's dependency after version 5.

@AlexWayfer
Copy link
Contributor

@AlexWayfer Faraday is no longer the SDK's dependency after version 5.

Sorry, my bad, there left other dependencies after 4→5 update.

@adis-io
Copy link

adis-io commented Jun 27, 2023

Hi, any dates on when sentry-raven stops working

@jeffwidman
Copy link
Contributor

Looks like this was scheduled for removal in v5 but accidentally left in, so should probably ship with v6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants