Update to Unity 2022.3.55f1 #1938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
For some reason when exporting the to the
|
bruno-garcia
force-pushed
the
chore/unity-2022.3.55f1
branch
3 times, most recently
from
ec22fe6 to
f6a04fa
Compare
bruno-garcia
force-pushed
the
chore/unity-2022.3.55f1
branch
2 times, most recently
from
e104120 to
46649b7
Compare
bitsandfoxes
force-pushed
the
chore/unity-2022.3.55f1
branch
from
46649b7 to
e104120
Compare
| @@ -9,7 +9,7 @@ namespace Sentry.Unity.Android; | |||
| internal class JniExecutor : IJniExecutor | |||
| { | |||
| // We're capping out at 16ms - 1 frame at 60 frames per second | |||
| private static readonly TimeSpan DefaultTimeout = TimeSpan.FromMilliseconds(16); | |||
| private static readonly TimeSpan DefaultTimeout = TimeSpan.FromMilliseconds(2000); | |||
There was a problem hiding this comment.
What is this timeout used for? The comment above indicates some relationship to giving up after causing 1 frame dropped. 2 seconds is quite large of a UI freeze
| @@ -44,7 +44,7 @@ public static void Configure(SentryUnityOptions options, ISentryUnityInfo sentry | |||
| options.DiagnosticLogger?.LogDebug("The Android SDK is already initialized"); | |||
| } | |||
| // Local testing had Init at an average of about 25ms. | |||
| else if (!SentryJava.Init(JniExecutor, options, TimeSpan.FromMilliseconds(200))) | |||
| else if (!SentryJava.Init(JniExecutor, options, TimeSpan.FromMilliseconds(2000))) | |||
There was a problem hiding this comment.
Ideally we control these timeouts centrally, and name them in a meaninful way so we know what they are representing.
bruno-garcia
force-pushed
the
chore/unity-2022.3.55f1
branch
from
1b8fa25 to
d764ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Auto-generated by create-pull-request