Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate CI jobs into workflows #1989

Merged
merged 19 commits into from
Jan 29, 2025
Merged

feat: Separate CI jobs into workflows #1989

merged 19 commits into from
Jan 29, 2025

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jan 23, 2025

Addresses the first part of #1975

This separates the jobs that were targeting multiple platforms into individual workflows, responsible for a singular purpose. I.e.

  1. platform-smoke-test-build
  2. platform-smoke-test-compile
  3. platform-smoke-test-run

The restructuring of jobs also netted a nice speed increase from 55 down to about 30 minutes.
I.e.

  • Creating the empty smoke test project right from the beginning
  • Having the job that installs the sentry package go through all of the setup required and then only wait for the UPM to be available to download while the SDK is building.

#skip-changelog

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 383acb1

@bitsandfoxes bitsandfoxes changed the title feat: Update CI feat: Separate CI jobs into workflows Jan 24, 2025
@bitsandfoxes bitsandfoxes mentioned this pull request Jan 24, 2025
3 tasks
@bitsandfoxes bitsandfoxes marked this pull request as ready for review January 24, 2025 17:49
@bitsandfoxes bitsandfoxes requested a review from vaind January 24, 2025 17:49
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me although I'm not a fan of duplicating the "*-smoke-test-build" from a single place (although with a couple of platform checks) to separate workflows. If this is about moving to a separate workflow file, maybe consider doing so but keeping a single copy. Alternatively, it could make sense to group the common set of subsequent steps to a single composite action.

Comment on lines 50 to 51
# Building the SDK with Unity 2022 and newer requires ns2.1 - skipping for now
unity-version: ["2019", "2020", "2021"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another unrelated one: maybe worth tracking this as well to add 2022 and 6000?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. The resulting artifacts are not usable for distribution but we could at least check whether it builds?

@bitsandfoxes
Copy link
Contributor Author

bitsandfoxes commented Jan 29, 2025

Looks pretty good to me although I'm not a fan of duplicating the "*-smoke-test-build" from a single place (although with a couple of platform checks) to separate workflows. If this is about moving to a separate workflow file, maybe consider doing so but keeping a single copy. Alternatively, it could make sense to group the common set of subsequent steps to a single composite action.

I'm splitting the changes into smaller, more digestible steps. I'm following up on the *-smoke-test-compile/smoke
in #1993 and merge build and compile into one, relying on Unity's environment instead of trying to recreate a working setup in a new job.

I'm more than happy to extract and compose this into composite actions once I get it working.

Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I'm fine with followups in separate issues/PRs

@bitsandfoxes bitsandfoxes merged commit 003a4d2 into main Jan 29, 2025
71 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/ci-refactor branch January 29, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants