-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Separate CI jobs into workflows #1989
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me although I'm not a fan of duplicating the "*-smoke-test-build" from a single place (although with a couple of platform checks) to separate workflows. If this is about moving to a separate workflow file, maybe consider doing so but keeping a single copy. Alternatively, it could make sense to group the common set of subsequent steps to a single composite action.
# Building the SDK with Unity 2022 and newer requires ns2.1 - skipping for now | ||
unity-version: ["2019", "2020", "2021"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another unrelated one: maybe worth tracking this as well to add 2022 and 6000?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. The resulting artifacts are not usable for distribution but we could at least check whether it builds?
Co-authored-by: Ivan Dlugos <[email protected]>
I'm splitting the changes into smaller, more digestible steps. I'm following up on the I'm more than happy to extract and compose this into composite actions once I get it working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I'm fine with followups in separate issues/PRs
Addresses the first part of #1975
This separates the jobs that were targeting multiple platforms into individual workflows, responsible for a singular purpose. I.e.
platform-smoke-test-build
platform-smoke-test-compile
platform-smoke-test-run
The restructuring of jobs also netted a nice speed increase from
55
down to about30
minutes.I.e.
#skip-changelog