chore(issues): Log warning instead of exception #101368
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We raise an exception when failing to parse a Snuba response, there is no need to also log an exception here since it otherwise results in 2 separate errors being logged for the same problem. Fixes SENTRY-5AGR
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/utils/snuba.py
|
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Oct 10, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| except ValueError: | ||
| if response.status != 200: | ||
| logger.exception( | ||
| logger.warning( |
There was a problem hiding this comment.
Bug: Log Level Downgrade Masks Parsing Errors
Changing logger.exception() to logger.warning() for Snuba JSON parsing ValueErrors loses the original traceback and error details. This also downgrades the log level from ERROR to WARNING, potentially breaking monitoring and making these parsing failures much harder to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We raise an exception when failing to parse a Snuba response, there is no need to also log an exception here since it otherwise results in 2 separate errors being logged for the same problem.
Fixes SENTRY-5AGR
See also SENTRY-5AGQ