Skip to content

Conversation

@mifu67
Copy link
Contributor

@mifu67 mifu67 commented Oct 21, 2025

Dupe of https://github.com/getsentry/getsentry/pull/17808 for self-hosted sentry.

@mifu67 mifu67 requested review from a team as code owners October 21, 2025 21:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 21, 2025
@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0997_backfill_self_hosted_sentry_app_emails.py

for 0997_backfill_self_hosted_sentry_app_emails in sentry

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we need to make this a job in getsentry at all? We could probably just run this as a post deploy migration and call it a day?

@mifu67
Copy link
Contributor Author

mifu67 commented Oct 21, 2025

Any reason we need to make this a job in getsentry at all? We could probably just run this as a post deploy migration and call it a day?

It's been a while and I don't really remember, but I don't see why we couldn't.

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Using migration models for the update will be fine as the outbox handlers for users synchronize data that won't exist in self-hosted, or is not relevant for sentryapp proxy users.

@getsantry
Copy link
Contributor

getsantry bot commented Nov 13, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 13, 2025
@mifu67 mifu67 removed the Stale label Nov 13, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Dec 5, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 5, 2025
@mifu67 mifu67 removed the Stale label Dec 5, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Dec 27, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants