feat(proguard): Mark synthesized methods on frames #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-wilfert
approved these changes
Jul 17, 2025
Depends on #1734. This adds a field `method_synthesized` to `JvmFrame` that denotes whether the frame's method was synthesized by the compiler.
loewenheim
force-pushed
the
sebastian/proguard-synthesized
branch
from
830cd56 to
beca4ea
Compare
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 22, 2025
As of getsentry/symbolicator#1735 Symbolicator returns a flag on Java stackframes with synthesized methods. We carry over this flag and additionally mark such frames as not in-app.
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 22, 2025
As of getsentry/symbolicator#1735 Symbolicator returns a flag on Java stackframes with synthesized methods. We carry over this flag and additionally mark such frames as not in-app. ref: #94408. ref: INGEST-432.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1734. This adds a field
method_synthesizedtoJvmFramethat denotes whether the frame's method was synthesized by the compiler.Closes #1720. Closes SYMBOLI-22.