Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Electron to latest version #9

Closed
magne4000 opened this issue Jul 14, 2021 · 1 comment
Closed

Upgrade Electron to latest version #9

magne4000 opened this issue Jul 14, 2021 · 1 comment
Labels
enhancement New feature or request outdated-electron Electron version is outdated/detected Chrome version is too old

Comments

@magne4000
Copy link
Member

Many bugs that are occurring are due to the outdated Electron version used.
Unfortunately upgrading Electron as always be a major difficulty on this project, and this time its still no luck as much work needs to be done to be able to upgrade to the latest version (or even just from v7 to v9).

Persistence layer

Context: What we learned from data persistence in our growing Electron app

sqlite3 package will not be able to be loaded inside Electron renderer process. All core logic is currently handled in a "worker" process, which is just a frameless renderer process. Persistence is a part of this.

We cannot easily replace the package with better-sqlite3 as its not compatible with sequelize. And we are not sure if it would completely work.

Best bet would be to get rid of sqlite and sequelize and use IndexedDb, as we are in a renderer process (at the time we wrote the article, the persistence was done in the main process).

BrowserWindow extension APIs

See https://www.electronjs.org/docs/breaking-changes#deprecated-browserwindow-extension-apis
Not sure if this will be a no brainer, but my guess is that it will probably not be as simple as the documentation suggests.

Deprecation of worldSafeExecuteJavaScript

See https://www.electronjs.org/docs/breaking-changes#default-changed-worldsafeexecutejavascript-defaults-to-true
It will probably have an impact, but its unknown yet.

Other minor changes

All (most?) of breaking changes are listed here https://www.electronjs.org/docs/breaking-changes. Things like changes in API names shouldn't be too difficult to migrate.

Of course, any other/better idea is welcome on the subject!

@magne4000 magne4000 added the enhancement New feature or request label Jul 14, 2021
@magne4000 magne4000 changed the title Upgrade Electron to lastest version Upgrade Electron to latest version Jul 14, 2021
@magne4000 magne4000 added the outdated-electron Electron version is outdated/detected Chrome version is too old label Jul 14, 2021
@Virgus
Copy link

Virgus commented Jul 14, 2021

Hello magne4000, I'm sorry I'm not skilled enough to be of some help, but just to mention a detail that might be of some help:
the electron version used in Canary version, despite is almost 18 months old, is working fine with everything I used so far.
https://github.com/getstation/station-canary/releases/tag/0.19.131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request outdated-electron Electron version is outdated/detected Chrome version is too old
Projects
None yet
Development

No branches or pull requests

3 participants