#9 Upgrade Electron to v24

[viktor44]

What is this PR

Upgraded to Electron 24

Fixed issues

• New user Outlook crashes the app when trying to open a new outlook tab #165
• Outlook Email, Android Messages Loading to Blank Screen #161
• Facebook Messenger and Instagram blank screen #151
• Facebook Messenger logs in succesfully than presents blank screen #143
• Gitlab will not load #108
• Upgrade Electron to latest version #9

[magne4000]

Perhaps store the result of this call so we just have to call it once per process.

[viktor44]

Perhaps store the result of this call so we just have to call it once per process.

I have doubts about this suggestion
Should we create a module for this purpose?
and then use it like

  const id = require('some-new-module').workerWebContentsId

What is the right place to put it?
Is this worker-id available in any moment of time and code? What if we ask for it too early?

[magne4000]

A module seems a little overkill, I was more thinking just storing the result of the call in a variable in the file itself

[viktor44]

That was my first version :)
Like this

  const workerWebContentsIdPromise = ipcRenderer.invoke('get-worker-contents-id');

  const sendPerformToProxy = (channel, payload) => {
    const p = new Promise(resolve => {
      ipcRenderer.once(`bx-api-perform-response-${channel}`, (_, result) => {
        resolve(result);
      });
    });

    setTimeout(() => {
        workerWebContentsIdPromise
            .then(workerWebContentsId => ipcRenderer.sendTo(workerWebContentsId, 'bx-api-perform', channel, payload));
    }, 1);
    return p;
  };

But the same concern about requesting it too early.
And setTimeout here looks like brute workaround, so I decided not to touch it and to keep as is.

[magne4000]

IDEM

[magne4000]

Migrated to node@18, the build version works, but yarn run dev does not, because I cannot forward --openssl-legacy-provider to the dev process (Electron forbids it). See webpack/webpack#14532

To fix that, we have multiple solutions:

• Webpack would need monkeypatching to replace all md4 usage to xxhash64
• Upgrade to webpack@5
• Upgrade to electron-forge

All those solutions are not trivial. Finding a way to force/monkeypatch output.hashFunction: "xxhash64" on webpack AND all its plugins would probably be the simplest solution.

I will not have time to continue working on this for the next few weeks, so feel free to take over this subject.

[viktor44]

But I have the same test error with Node 18

 FAIL  test/jest/bang/search/test-search.ts
  ● Test suite failed to run

    1:undefined
    undefined

      at Object.reject (node_modules/@jest-runner/rpc/build/RPCProcess.js:139:18)
      at Server.emit (node_modules/event-pubsub/es5.js:74:21)
      at Server.gotData (node_modules/node-ipc/dao/socketServer.js:194:14)

hence Node upgrade won't help with this problem

[magne4000]

The test is fixed, it was due to some weird import issue 🤷‍♂️

Now only remains to fix yarn run dev.

[viktor44]

I think we should migrate to Node 18 in a separate PR
This one is quite big already

[viktor44]

I also moved your yesterday commits to separate branch
https://github.com/viktor44/station-desktop-app/tree/feature/electron_24_node_18

[magne4000]

Electron 24 is tied to Node 18, so migrating one without the other is not a complete PR and will lead to unexpected behaviour.

[magne4000]

I found a quick way to monkeypatch crypto usage in webpack, the PR should be all good now

[magne4000]

@viktor44 Good to merge on my side. Ok for you too?

[viktor44]

@viktor44 Good to merge on my side. Ok for you too?

absolutely