Generate reflect::is_xxx() helpers directly in the spirv header
#269
+208
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
changed the title
reflect::is_type() directly in the spirv headerreflect::is_xxx() helpers directly in the spirv header
MarijnS95
force-pushed
the
inline-grammar
branch
from
d2d7351 to
64584d0
Compare
MarijnS95
force-pushed
the
inline-grammar
branch
from
64584d0 to
2c7d1b9
Compare
kvark
approved these changes
Oct 1, 2025
We've had a *lot* of bugs surfacing from the fact that the manual `rspirv::grammar::reflect` module required hand-adding various `spirv` ops to `match` statements to let the code behave, despite being able to very trivially autogenerate this based on the SPIR-V grammar. By doing so we find quite a few instructions that weren't handled by the hand-written table. For `is_type()` those are: - `OpTypePipeStorage` - `OpTypeNamedBarrier` - `OpTypeUntypedPointerKHR` - `OpTypeNodePayloadArrayAMDX` - `OpTypeHitObjectNV` - `OpTypeCooperativeVectorNV` - `OpTypeCooperativeMatrixNV` - `OpTypeTensorLayoutNV` - `OpTypeTensorViewNV` - `OpTypeBufferSurfaceINTEL` - `OpTypeStructContinuedINTEL` For `is_constant()`: - `OpConstantCompositeReplicateEXT` - `OpSpecConstantCompositeReplicateEXT` For `is_annotation()`: - `OpDecorateId` For `is_debug()` (via `is_nonlocation_debug()`): - `OpModuleProcessed` Unfortunately classes only convey the `Control-Flow` marker which doesn't provide enough detail to distinguish between returns, aborts or branches (or anything not specified). Even if our crates only ever call `is_block_terminator()` which is a composite of all those checks, not all `Control-Flow` opcodes are supposed to be treated as a terminator.
MarijnS95
force-pushed
the
inline-grammar
branch
from
2c7d1b9 to
f42eaf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a lot of bugs surfacing from the fact that the manual
rspirv::grammar::reflectmodule required hand-adding variousspirvops tomatchstatements to let the code behave, despite being able to very trivially autogenerate this based on the SPIR-V grammar. By doing so we find quite a few instructions that weren't handled by the hand-written table. Foris_type()those are:OpTypePipeStorageOpTypeNamedBarrierOpTypeUntypedPointerKHROpTypeNodePayloadArrayAMDXOpTypeHitObjectNVOpTypeCooperativeVectorNVOpTypeCooperativeMatrixNVOpTypeTensorLayoutNVOpTypeTensorViewNVOpTypeBufferSurfaceINTELOpTypeStructContinuedINTELFor
is_constant():OpConstantCompositeReplicateEXTOpSpecConstantCompositeReplicateEXTFor
is_annotation():OpDecorateIdFor
is_debug()(viais_nonlocation_debug()):OpModuleProcessedUnfortunately classes only convey the
Control-Flowmarker which doesn't provide enough detail to distinguish between returns, aborts or branches (or anything not specified). Even if our crates only ever callis_block_terminator()which is a composite of all those checks, not allControl-Flowopcodes are supposed to be treated as a terminator.