don't set autoresizing mask on ios as that's not supported #6535
+24
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
bevyengine/bevy#16363
Description
After updating to wgpu 23, Bevy crashes on iOS with
fatal runtime error: Rust cannot catch foreign exceptions
This started with #6107
By adding logging between all lines of code in the
get_metal_layer
, it came fromwgpu/wgpu-hal/src/metal/surface.rs
Line 226 in ae6c6fb
new_layer is a
CAMetalLayer
which is available on iOS https://developer.apple.com/documentation/quartzcore/cametallayerbut
autoresizingMask
is only available on macOS https://developer.apple.com/documentation/quartzcore/calayer/1410877-autoresizingmaskthis PR stops setting the
autoresizingMask
on iOSTesting
I tested the same fix on the 23 tag with Bevy and it works
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.