Fix workgroupUniformLoad returning atomic types #8791
+524
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inner-daemons
suggested changes
Dec 29, 2025
Collaborator
inner-daemons
left a comment
inner-daemons
left a comment
There was a problem hiding this comment.
Thanks for this! Broadly LGTM, just a few suggestions
inner-daemons
approved these changes
Dec 30, 2025
Collaborator
inner-daemons
left a comment
inner-daemons
left a comment
There was a problem hiding this comment.
LGTM! Thanks for working on this. Probably it will get merged sometime around the 7th.
Comment on lines
+1482
to
+1483
| // workgroupUniformLoad on atomic<T> returns T, not atomic<T>. | ||
| // Verify the pointer's atomic scalar matches the result scalar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
FIxes #8785.
Description
workgroupUniformLoadnow matches the spec and returns the inner type when called on an atomic.Testing
Added a new snapshot test
workgroup-uniform-load-atomic.wgslSquash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.