Skip to content

Conversation

@Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Jan 20, 2026

Connections

Description
This PR take advantage of changes from encode on finish to reduce the number of temporary vectors and do BLAS processing in one less pass. Also swapped some Vec::news to Vec::with_capacity because the capacity is now known.

A notable benefit of this is that implementing custom geometry (AABBs) should be easier because previously the intermediate vector storage assumed that all geometries were triangle geometries.

Note: first commit & most of the second commit are refactors without changing names to try and make things easier to compare - I recommend reviewing the first one w/o whitespace diffs to check no validation has been removed. (These first few commits also don't compile) The next few commits are for changing the references.

Testing
Uses existing tests

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • Run cargo clippy --tests.
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry. No user facing changes.

@inner-daemons inner-daemons self-requested a review January 21, 2026 16:16
@cwfitzgerald cwfitzgerald self-assigned this Jan 21, 2026
@inner-daemons inner-daemons self-assigned this Jan 21, 2026
@inner-daemons
Copy link
Collaborator

I'd like to look at this but almost more out of curiosity than because I think I can provide a proper review. So this shouldn't block a review by @cwfitzgerald.

@Vecvec Vecvec force-pushed the Refactor-as-build branch from c318bad to c36ecf9 Compare January 26, 2026 18:19
@Vecvec Vecvec force-pushed the Refactor-as-build branch from c36ecf9 to 85df7f7 Compare January 26, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants