Skip to content

Conversation

@andyleiserson
Copy link
Contributor

Fixes two issues with const evaluation of bitwise shifts:

  • Disallows mixed scalar/vector shifts (scalar << vector or vector << scalar), which should not be allowed.
  • Detects overflowing runtime << constant shifts at constant evaluation time.

Also includes, as a separate commit, cleanup of some noisy log messages in the naga expression validator.

Testing
Enables CTS tests.

Squash or Rebase? Rebase

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@teoxoy
Copy link
Member

teoxoy commented Jan 26, 2026

Looks like CI is unhappy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants