Skip to content

dx12: Enable Rgba8Unorm storage textures for DirectComposition transparency #8908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joeleaver wants to merge 1 commit into
base: trunk
Choose a base branch
from
+16 −0
Open

dx12: Enable Rgba8Unorm storage textures for DirectComposition transparency #8908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions wgpu-core/src/instance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,22 @@ impl Adapter {
caps.contains(Tfc::STORAGE_READ_WRITE),
);

// Force storage write capability for common formats that modern GPUs support
// but DX12 may not correctly report via D3D12_FORMAT_SUPPORT2_UAV_TYPED_STORE.
// This is needed for Vello's compute shaders which use Rgba8Unorm storage textures.
// See: https://github.com/gfx-rs/wgpu/issues/8670
if matches!(
format,
wgt::TextureFormat::Rgba8Unorm
| wgt::TextureFormat::Rgba8Snorm
| wgt::TextureFormat::Bgra8Unorm
) {
flags.set(wgt::TextureFormatFeatureFlags::STORAGE_READ_ONLY, true);
flags.set(wgt::TextureFormatFeatureFlags::STORAGE_WRITE_ONLY, true);
flags.set(wgt::TextureFormatFeatureFlags::STORAGE_READ_WRITE, true);
allowed_usages.set(wgt::TextureUsages::STORAGE_BINDING, true);
}

flags.set(
wgt::TextureFormatFeatureFlags::STORAGE_ATOMIC,
caps.contains(Tfc::STORAGE_ATOMIC),
Expand Down
Loading