fix(naga): Reject unsupported enable extensions #8913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleiserson
force-pushed
the
jj-push-vvqq
branch
from
612e257 to
7a38061
Compare
Previously we required that the enable extension be declared and that the capability be present if the functionality was used, but allowed the extension to be declared if the functionality was not used.
andyleiserson
force-pushed
the
jj-push-vvqq
branch
from
7a38061 to
492f376
Compare
Collaborator
|
@andyleiserson Not necessarily related to this PR, but the WGSL errors test file is getting pretty long. Should we consider splitting it up into different files/modules? It might also just not matter which is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #8871.
@inner-daemons pointed out that we weren't actually rejecting shaders specifying an unsupported enable extension if they didn't use the functionality.
This change corrects that.
Testing
Adds tests in
wgsl_errorsand a GPU test.Squash or Rebase? Squash (after #8871 is merged)
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.