Move ordered usages to hals#8924
Conversation
|
I'm interested in this so I'll take a look at some point, but I can't merge it myself. |
|
I'm just gonna let any future reviewer know than in this comment, this patch is confirmed to work. That makes multiple people with the bug completely going away so this is almost certainly the right fix. Thanks for this @NiklasEi, we'll try to review & merge it soon-ish, plus I asked the maintainers about backporting this so it appears in a patch release like 28.0.1 rather than being pushed off until the next release in 2 months. Valuable stuff! |
inner-daemons
left a comment
There was a problem hiding this comment.
A few comments/questions. Broadly LGTM! Also make sure to add a changelog entry
There are two entries now, one for the general move of ordered uses to the hals and one for the fix in Vulkan, I hope that is OK. |
db9c4e1 to
996c810
Compare
There was a problem hiding this comment.
Thank you for tackling this! Mostly comments about naming and docs. I have commented on a few names, though there are more places where the same pattern should be applied - I want to make sure that new readers of the code understand what exactly the members represent.
inner-daemons
left a comment
There was a problem hiding this comment.
Reading through the changes here gave me a headache, its 99% just passing around the same stuff. You couldn't pay me to spend another minute looking at this. Nothing controversial though, lets get this merged
cwfitzgerald
left a comment
There was a problem hiding this comment.
I have an idea for a different design for this, but lets land this and I'll file an issue about a potential different design
|
Thank you! |
Connections
Resolves #8853 (and thus bevyengine/bevy#14710)
Description
Currently, ordered usage is defined globally for all hals. According to #8853 this is problematic and the current ordered usages are not correct for Vulkan.
This PR moves the ordered usages into the different hals. It also removes the two wrong ordered usages for Vulkan.
Testing
I ran the standalone examples on my linux machine (NVIDIA RTX 2000 Ada).
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.trunkCHANGELOG.mdentry.