Skip to content

Conversation

@NiklasEi
Copy link

Connections
Resolves #8853 (and thus bevyengine/bevy#14710)

Description
Currently, ordered usage is defined globally for all hals. According to #8853 this is problematic and the current ordered usages are not correct for Vulkan.
This PR moves the ordered usages into the different hals. It also removes the two wrong ordered usages for Vulkan.

Testing
I ran the standalone examples on my linux machine (NVIDIA RTX 2000 Ada).

Squash or Rebase?

Rebase

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
    • I have 15 failing tests, but the same are also failing on latest trunk
    • FAIL [   0.004s] naga::naga snapshots::convert_snapshots_spv
      FAIL [   1.680s] wgpu-examples [Executed Failure: BACKEND] [Vulkan/Intel(R) Graphics (RPL-S)/0] water
      FAIL [   1.790s] wgpu-examples [Executed Failure: BACKEND] [Vulkan/llvmpipe (LLVM 19.1.1, 256 bits)/2] water
      FAIL [   0.180s] wgpu-examples [Executed] [Vulkan/Intel(R) Graphics (RPL-S)/0] wgpu_examples::cooperative_matrix::tests::cooperative_matrix
      FAIL [   3.807s] wgpu-examples [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] multiple_render_targets
      FAIL [   3.638s] wgpu-examples [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] skybox-bc7
      FAIL [   3.726s] wgpu-examples [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] skybox-etc2
      FAIL [   5.871s] wgpu-test::wgpu-gpu [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] wgpu_gpu::clear_texture::clear_texture_uncompressed_gles
      FAIL [   5.571s] wgpu-examples [Executed Failure: BACKEND] [Vulkan/NVIDIA RTX 2000 Ada Generation Laptop GPU/1] water
      FAIL [   2.563s] wgpu-examples [Executed] [Vulkan/NVIDIA RTX 2000 Ada Generation Laptop GPU/1] wgpu_examples::cooperative_matrix::tests::cooperative_matrix
      FAIL [   2.107s] wgpu-test::wgpu-gpu [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] wgpu_gpu::render_target::draw_to_2d_view
      FAIL [   2.057s] wgpu-test::wgpu-gpu [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] wgpu_gpu::render_target::draw_to_3d_view
      FAIL [   2.259s] wgpu-test::wgpu-gpu [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] wgpu_gpu::render_target::draw_to_2d_array_view
      FAIL [   2.161s] wgpu-test::wgpu-gpu [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] wgpu_gpu::render_target::resolve_to_2d_array_view
      FAIL [   2.224s] wgpu-test::wgpu-gpu [Executed] [Gl/NVIDIA RTX 2000 Ada Generation Laptop GPU/PCIe/SSE2/3] wgpu_gpu::render_target::resolve_to_2d_view
      
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@inner-daemons inner-daemons self-requested a review January 26, 2026 01:57
@inner-daemons
Copy link
Collaborator

I'm interested in this so I'll take a look at some point, but I can't merge it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulkan backend incorrectly skips barriers

2 participants