Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv: allow non-multiline to search beyond monitor limit #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MSMazaya
Copy link

@MSMazaya MSMazaya commented Apr 20, 2023

Hi! I am using Flit for inline search and found that I miss the functionality that the default vim f/F has: the capability on searching beyond the monitor limit. For example, in the following video, I have a non-wrap markdown opened and I can't get to : with Flit, with this PR this would be possible.

2023-04-21.06-31-12.mp4

@ggandor
Copy link
Owner

ggandor commented Apr 29, 2023

Hi, thanks! The problem with this simple workaround is that flit will label invisible positions, which is confusing. There are lots of possible ways to handle off-screen matches if we want that (we might tweak Leap itself), I have to think about it more.

@MSMazaya
Copy link
Author

The problem with this simple workaround is that Flit will label invisible positions

I see, indeed that will be a problem. I got a few suggestions:

  1. What if I change it so that labels are present only for on-screen targets but still allow off-screen targets to be traversed via repeat motion only for inline search targets (because if this behavior exists on multiline search, it will be confusing)? But I guess this means that there will be necessary changes to Leap
  2. Or maybe should it be turned into a configuration instead so people will expect this (invisible positions existence) if they turn it on?

What are your thoughts?

There are lots of possible ways to handle off-screen matches if we want that (we might tweak Leap itself)

What are your ideas to do so? I will be happy to contribute/be assigned to this issue/feature :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants