-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make : deprecate #10514
make : deprecate #10514
Conversation
That would be a much more preferred option. Like LostRuins mentioned in the original discussion, Makefile is a very simple and handy option that gives additional flexibility to projects that use llama.cpp, and it is multiplatform. If you see the current state of Makefile as a burden, it is worth at least leaving a simplified version - for example, |
Is there a single platform that does not have easy access to cmake? If typing two commands instead of one is too much effort, we can always have the |
bcafa92
to
fb6e8b1
Compare
4d4742a
to
38797c7
Compare
38797c7
to
328ded3
Compare
Need to fix the |
3c29b91
to
bbff53a
Compare
Very nice! |
Co-authored-by: Diego Devesa <[email protected]>
This breaks the SRPM specs again. Does anybody who uses the RPM specs have a preference for cmake+libs vs make+static builds? The rate things change in cmake I'm tempted to just stick with static Makefile builds, rather than mess with rpath issues, shared objects, and extra binaries. |
If you want a static build just disable I am not sure how people are using the RPMs, but if the goal is to distribute binaries, then you should use shared libraries, |
Ref: ggerganov/llama.cpp#10514 The recommended way to build llama.cpp is by using `cmake` command.
Makefile is being deprecated. Stick with static builds using cmake and skip rpaths checks. ggerganov#10514
Unfortunately packaging RPMs isn't quite so simple. Every time a build change refactors out a different library or file the rpm inventory needs to be updated to list which files it includes. This was breaking quite a bit of my COPR build automation as updates arrived so I stuck with static builds. I suppose the proper way to do this would be refactor out separate RPMs for just libs and server binaries, etc. |
* make : deprecate ggml-ci * ci : disable Makefile builds ggml-ci * docs : remove make references [no ci] * ci : disable swift build ggml-ci * docs : remove obsolete make references, scripts, examples ggml-ci * basic fix for compare-commits.sh * update build.md * more build.md updates * more build.md updates * more build.md updates * Update Makefile Co-authored-by: Diego Devesa <[email protected]> --------- Co-authored-by: slaren <[email protected]>
* make : deprecate ggml-ci * ci : disable Makefile builds ggml-ci * docs : remove make references [no ci] * ci : disable swift build ggml-ci * docs : remove obsolete make references, scripts, examples ggml-ci * basic fix for compare-commits.sh * update build.md * more build.md updates * more build.md updates * more build.md updates * Update Makefile Co-authored-by: Diego Devesa <[email protected]> --------- Co-authored-by: slaren <[email protected]>
ref #10268
Disabling the Makefile unless
LLAMA_MAKEFILE
is defined. This should give more focus for the CMake build and will help clean-up any usage ofmake
in the existing CI. The Makefile will be eventually removed or stripped to a very minimal version.