Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix for building with no internet connection #10706

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Man2Dev
Copy link
Contributor

@Man2Dev Man2Dev commented Dec 7, 2024

This PR will ensure that the test for curl integration in llama.cpp is only conducted if an internet connection is available. If no internet is available, it
will simply provide a warning and not test the curl integration.

The reason for this PR is to allow all other tests to be used in environments where internet access is not available at build time without causing the tests to
fail. For example, in Fedora/RedHat package build systems like mock [1], where no internet is provided during the build process.

[1] https://rpm-software-management.github.io/mock/

@Man2Dev Man2Dev changed the title fix for building with no internet connection cmake: fix for building with no internet connection Dec 7, 2024
@ggerganov
Copy link
Owner

This is not a good way to fix this. Instead, there should be an option to filter tests that require internet connection and this option can be optionally set during CMake configure step.

@Man2Dev Man2Dev marked this pull request as draft December 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants