llamafile_sgemm API - INT8 implementation #10912
Open
+643
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
amritahs-ibm
force-pushed
the
sgemm_q8
branch
from
3c60b12 to
85c5280
Compare
This change upstreams llamafile's cpu matrix multiplication kernels for ppc64le using MMA builtins for quantised int8 datatype. This change results in 10% - 70% improvement in total speed(ie all tokens/total time), across various batch sizes. The patch is tested with Meta-Lllama-3-8B, Mistral-7B, Llama-2-7B-chat-hf models on a IBM POWER10 machine. Signed-off-by: Amrita H S <[email protected]>
amritahs-ibm
force-pushed
the
sgemm_q8
branch
from
85c5280 to
d70f5fc
Compare
|
Hi @ggerganov, |
|
We will need to merge #10714 first, since there may be some conflicts. |
|
Sure. Please let me know once that PR is merged. I will fix mine, if any conflicts and resubmit my PR. |
|
I'll try to submit it today. 🤞 |
Djip007
reviewed
Dec 24, 2024
| k, (const block_q8_0 *)A, lda, | ||
| (const block_q8_0 *)B, ldb, | ||
| (float *)C, ldc, | ||
| ith, nth}; |
There was a problem hiding this comment.
with #10714
You will have to take ith/nth from params->ith/params->ith. It may be the only change you need to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change upstreams llamafile's cpu matrix
multiplication kernels for ppc64le using MMA
builtins for quantised int8 datatype.
This change results in 10%-70% improvement
in total speed(ie all tokens/total time), across
various batch sizes.
The patch is tested with Meta-Lllama-3-8B,
Mistral-7B, Llama-2-7B-chat-hf models on a
IBM POWER10 machine.