Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server : add OAI compat for /v1/completions #10974

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

server : add OAI compat for /v1/completions #10974

wants to merge 4 commits into from
+400 −146

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Dec 25, 2024 •
edited
Loading

Supersede #10645

Ref documentation: https://platform.openai.com/docs/api-reference/completions/object

The /v1/completions endpoint can now be OAI-compatible (not to be confused with /completion endpoint, without /v1 prefix)

Also regrouped the docs to have 2 dedicated sections: one for OAI-compat API and one for non-OAI API

TODO:

  • add test
  • add docs

@github-actions github-actions bot added the python python script changes label Dec 25, 2024
@ngxson ngxson added the breaking change Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility. label Dec 25, 2024
@ngxson ngxson marked this pull request as ready for review December 25, 2024 16:05
@ngxson ngxson requested a review from ggerganov December 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov Awaiting requested review from ggerganov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking change Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility. examples python python script changes server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ngxson