Skip to content

Fix a few small Windows / MSVC build issues #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tlemo
Copy link

@tlemo tlemo commented Apr 14, 2025

The latest MSVC reports a few compilation problems (#1194)

ggml\tests\test-pad-reflect-1d.cpp(28): error C7555: use of designated initializers requires at least '/std:c++20'
ggml\tests\test-pad-reflect-1d.cpp(89): error C7555: use of designated initializers requires at least '/std:c++20'
ggml\tests\test-pad-reflect-1d.cpp(88): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax
ggml\tests\test-pad-reflect-1d.cpp(148): error C7555: use of designated initializers requires at least '/std:c++20'
ggml\tests\test-pad-reflect-1d.cpp(147): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax

@slaren
Copy link
Member

slaren commented Apr 14, 2025

It would be preferable to fix the code to require only C++17, rather than changing the standard which will create more issues with compilers that still do not support C++20.

@tlemo
Copy link
Author

tlemo commented Apr 15, 2025

It would be preferable to fix the code to require only C++17, rather than changing the standard which will create more issues with compilers that still do not support C++20.

Sure. I updated the changes to fix the MSVC build and stick to C++17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants