ggml-cpu : remove stdlib include from repack.cpp #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbev
force-pushed
the
repack-remove-cstdlib
branch
from
fb71d5d to
cfc3525
Compare
danbev
changed the title
|
There will be some more refactoring of this code soon (ggml-org/llama.cpp#14134 (comment)) and after we sync them from |
I believe the sync was been done so perhaps we can merge this now (just needs an approval). |
This commit removes the inclusion of `<cstdlib>`. The motivation for this change is that this source file does not seem to use any functions from this header and the comment about `qsort` is a little misleading/confusing.
danbev
force-pushed
the
repack-remove-cstdlib
branch
from
cfc3525 to
91cd72a
Compare
slaren
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the inclusion of
<cstdlib>.The motivation for this change is that this source file does not seem to use any functions from this header and the comment about
qsortis a little misleading/confusing.