Skip to content

llama : allow building all tests on windows when not using shared libs #13980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slaren
Copy link
Member

@slaren slaren commented Jun 2, 2025

The current condition is unnecessarily strict, when building without shared libraries (BUILD_SHARED_LIBS=OFF) the tests can still be built on windows.

@github-actions github-actions bot added the testing Everything test related label Jun 2, 2025
@slaren
Copy link
Member Author

slaren commented Jun 2, 2025

test-chat fails on Windows.

[test_msg_diffs_compute]
[test_msgs_oaicompat_json_conversion]
[test_tools_oaicompat_json_conversion]
[test_template_output_parsers]
# Reading: models/templates/CohereForAI-c4ai-command-r-plus-tool_use.jinja
# Reading: models/templates/CohereForAI-c4ai-command-r7b-12-2024-tool_use.jinja
# Reading: models/templates/google-gemma-2-2b-it.jinja
# Reading: models/templates/microsoft-Phi-3.5-mini-instruct.jinja
# Reading: models/templates/mistralai-Mistral-Nemo-Instruct-2407.jinja
Expected:
Actual: [TOOL_CALLS][{"name": "special_function", "arguments": {"arg1": 1}, "id": "123456789"}]

@github-actions github-actions bot added the devops improvements to build systems and github actions label Jun 3, 2025
@ggerganov
Copy link
Member

cc @ochafik Any ideas why it fails on Windows?

@CISC
Copy link
Collaborator

CISC commented Jun 3, 2025

cc @ochafik Any ideas why it fails on Windows?

My guess would be the regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions testing Everything test related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants