chore(server): split context-server to its own file #13987
+3,624
−3,621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mm not sure about https://github.com/ggml-org/llama.cpp/actions/runs/15414213443/job/43373059365?pr=13987 - it compiles fine locally here. It looks just a timeout? |
This is in order to improve maintainability and re-usability by downstream projects such as LocalAI (see mudler/LocalAI#5379 for context). The context server is a struct that can be re-used quite heavily by other communication protocols. For instance, LocalAI uses the context server on top of gRPC rather than having a REST API. This change improves overall re-usability by isolating the REST API to its own file so the context server can be imported easily. Signed-off-by: mudler <[email protected]>
mudler
force-pushed
the
chore/split_context_server
branch
from
de17206 to
b7f15f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in order to improve maintainability and re-usability by downstream projects such as LocalAI (see mudler/LocalAI#5379 for context).
The context server is a struct that can be re-used quite heavily by other communication protocols. For instance, LocalAI uses the context server on top of gRPC rather than having a REST API. This change improves overall re-usability by isolating the REST API to its own file so the context server can be imported easily.
cc @ggerganov @ngxson would be great guys if we could upstream this change. This would really help us to streamline llama.cpp integration and have less moving pieces. C++ ain't my cup of tea, so I'm not sure I've done anything according to llama.cpp/C++ standards, feedback is welcome and I'd be happy to address it!
Make sure to read the contributing guidelines before submitting a PR