server: Add ability to mount server at prefix #14544
Open
+41
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Jul 6, 2025
| @@ -4800,20 +4800,22 @@ int main(int argc, char ** argv) { | |||
| // Router | |||
| // | |||
|
|
|||
| const char* server_prefix = params.server_prefix.c_str(); | |||
There was a problem hiding this comment.
Suggested change
| const char* server_prefix = params.server_prefix.c_str(); | |
| const char * server_prefix = params.server_prefix.c_str(); |
ngxson
reviewed
Jul 6, 2025
| @@ -2734,6 +2734,13 @@ common_params_context common_params_parser_init(common_params & params, llama_ex | |||
| params.public_path = value; | |||
| } | |||
| ).set_examples({LLAMA_EXAMPLE_SERVER}).set_env("LLAMA_ARG_STATIC_PATH")); | |||
| add_opt(common_arg( | |||
| {"--prefix"}, "PREFIX", | |||
There was a problem hiding this comment.
--prefix can be quite vague to understand, risk of clashing with other features in the future. I think it should be --api-prefix for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a helpful feature in cases where the server is behind a reverse proxy mounted on a non root path.