server : refactor oai_parser_opt, move it to server_chat_params #18937
+112
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwilkin
approved these changes
Jan 19, 2026
tools/server/server-context.cpp
Outdated
|
|
||
| // print sample chat example to make it clear which template is used | ||
| // @ngxson modern templates are too long, spam the logs; printing the example is enough | ||
| LOG_INF("%s: chat template, example_format: '%s'\n", __func__, |
Collaborator
There was a problem hiding this comment.
Maybe move this to after line 881 instead of calling example twice? If we fallback to chatml we don't really need to print the example.
Collaborator
Author
There was a problem hiding this comment.
nice catch, I removed the chatml fallback logic altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
oaicompat_parser_options-->server_chat_paramscommon_chat_templates_ptrinside itctx_server.get_meta()now returnscommon_chat_templates_ptrcli.cpp; this should allow defining tools from CLI in the future