-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecation warnings with lifecycle #496
Open
92amartins
wants to merge
9
commits into
ggobi:master
Choose a base branch
from
92amartins:lifecycle-deprecations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92amartins
changed the title
chore: Update deprecation warnings in ggally_cor function
Update deprecation warnings with Lifecycle
Apr 18, 2024
92amartins
changed the title
Update deprecation warnings with Lifecycle
Update deprecation warnings with lifecycle
Apr 18, 2024
92amartins
force-pushed
the
lifecycle-deprecations
branch
from
April 18, 2024 23:41
01d3478
to
349d440
Compare
schloerke
reviewed
Apr 23, 2024
schloerke
reviewed
Apr 23, 2024
schloerke
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is a follow up from #494. Both aim to fix #365.
In this PR, we update deprecation warnings in the folllowing files:
R/gg-plots.R
R/deprecated.R
R/gg_matrix_gtable.R
R/ggnet.R