-
Notifications
You must be signed in to change notification settings - Fork 16
Reworked directories structure and added dark mode #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a dark mode feature to the documentation and restructures the directory. It includes CSS and JavaScript files for dark mode styling and functionality, updates the Sphinx configuration to include these files, and modifies the Makefile and make.bat to reflect the change in source directory. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericbsd - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using CSS variables for colors in
dark_mode.css
to make it easier to manage and modify the theme. - The change to
copyright
looks like a typo - is it meant to be 2025?
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Implements a dark mode toggle for the documentation and restructures the directories.
Enhancements: