-
-
Notifications
You must be signed in to change notification settings - Fork 37
clear /tmp by default #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request enables the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Izder456 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It would be good to understand the implications of this change by testing a live ISO build.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Vic Thacker's GitHub repositories and scripts exist for historical purposes. The repositories should not be considered current work. |
FWIW I was referring to a script he sent on telegram. |
I was messing with @vic-thacker's scripts in /tmp and noticed that /tmp wasn't being cleared by default. IMHO, this is a weird behaviour. By not clearing /tmp, we run the risk of filling up / with unneeded temporary files that running a desktop system creates, like dbus's tmp files for example. This shouldn't break live sessions, though I haven't tested a live ISO built with this commit. Thoughts?
Summary by Sourcery
Enable clearing of temporary files in /tmp directory by default during system configuration
Enhancements:
Chores: