Skip to content

clear /tmp by default #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

clear /tmp by default #215

merged 1 commit into from
Apr 2, 2025

Conversation

Izder456
Copy link
Member

@Izder456 Izder456 commented Apr 2, 2025

I was messing with @vic-thacker's scripts in /tmp and noticed that /tmp wasn't being cleared by default. IMHO, this is a weird behaviour. By not clearing /tmp, we run the risk of filling up / with unneeded temporary files that running a desktop system creates, like dbus's tmp files for example. This shouldn't break live sessions, though I haven't tested a live ISO built with this commit. Thoughts?

Summary by Sourcery

Enable clearing of temporary files in /tmp directory by default during system configuration

Enhancements:

  • Improve system disk space management by automatically removing unnecessary temporary files

Chores:

  • Add system configuration to automatically clear temporary files at system startup

@Izder456 Izder456 requested review from a team as code owners April 2, 2025 15:48
Copy link
Contributor

sourcery-ai bot commented Apr 2, 2025

Reviewer's Guide by Sourcery

This pull request enables the clear_tmp_enable service by default. This ensures that the /tmp directory is cleared on system startup, preventing the accumulation of unnecessary temporary files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enabled the clearing of the /tmp directory on system startup.
  • Added a line to enable the clear_tmp_enable service.
build.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Izder456 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It would be good to understand the implications of this change by testing a live ISO build.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Development Management Apr 2, 2025
@ericbsd ericbsd merged commit 49120d2 into ghostbsd:master Apr 2, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Management Apr 2, 2025
@ghost
Copy link

ghost commented Apr 2, 2025

Vic Thacker's GitHub repositories and scripts exist for historical purposes. The repositories should not be considered current work.

@Izder456
Copy link
Member Author

Izder456 commented Apr 4, 2025

Vic Thacker's GitHub repositories and scripts exist for historical purposes. The repositories should not be considered current work.

FWIW I was referring to a script he sent on telegram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants