Skip to content

Adding code to prevent multiple PKGBASE notifications. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Aug 20, 2024

Summary by Sourcery

Add a new boolean flag 'pkgbase_upgrade_shown' to the Data class to prevent multiple PKGBASE notifications.

New Features:

  • Introduce a flag to track whether a PKGBASE upgrade notification has been shown.

@ericbsd ericbsd requested review from a team as code owners August 20, 2024 21:40
@ericbsd ericbsd self-assigned this Aug 20, 2024
@ericbsd ericbsd added the bug label Aug 20, 2024
Copy link
Contributor

sourcery-ai bot commented Aug 20, 2024

Reviewer's Guide by Sourcery

This pull request adds a new boolean attribute pkgbase_upgrade_shown to the Data class in the src/update_data.py file. This change is likely implemented to prevent multiple notifications for PKGBASE upgrades.

File-Level Changes

Files Changes
src/update_data.py Added a new boolean attribute pkgbase_upgrade_shown to the Data class, initialized to False.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ericbsd ericbsd merged commit dd52400 into master Aug 20, 2024
1 check passed
@ericbsd ericbsd deleted the fix-pkgbsd-notification branch August 20, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant