Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scriptlet argument parsing #4416

Closed
wants to merge 1 commit into from
Closed

fix: scriptlet argument parsing #4416

wants to merge 1 commit into from

Conversation

seia-soto
Copy link
Member

fixes #4415

@seia-soto seia-soto added PR: Bug Fix 🐛 Increment patch version when merged WIP labels Oct 31, 2024
@seia-soto seia-soto self-assigned this Oct 31, 2024
@seia-soto seia-soto changed the title refactor: scriptlet argument parsing fix: scriptlet argument parsing Oct 31, 2024
@seia-soto
Copy link
Member Author

Generated parsing capability comparison result from https://github.com/seia-soto/adblocker-scriptlet-parsing-test/tree/main

result.md

@seia-soto
Copy link
Member Author

The result shows that new logic fails on:

  • Ignore commas with quotes: e.g. ##+js(rmnt, script, '"").split(",")[4]')
  • Drop .js suffix: e.g. ##+js(cookie-remover.js, articlesRead) (but we don't need this in actual)

@seia-soto
Copy link
Member Author

Needs more investigation, closing for now and will reopen another one with better direction.

@seia-soto seia-soto closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao Awaiting requested review from remusao remusao will be requested when the pull request is marked ready for review remusao is a code owner

Assignees

@seia-soto seia-soto

Labels
PR: Bug Fix 🐛 Increment patch version when merged WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scriptlet argument parsing
1 participant
@seia-soto