-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added full plotly support and fixed bugs with ggplot2 plots #58
Conversation
andbe
commented
Jan 8, 2024
- ceplane ggplot and plotly fixes
- added ceef plotly
- ceac ggplot and plotly fixes
- added contour, contour2 plotly
- fixed contour, contour2 ggplot
- added bcea.plot plotly
- added CEriskav plotly
* fixed issue with ICERs not plottable with plotly * fixed issue with points cloud not resizable with plotly * added comparison label to ICER points with plotly * fixed issue with legend positions in corners (eg topleft) with ggplot * added different default values in prep_ceplane_params with plotly, passing the graph parameter to the function
* fixed bug in "right" legend positioning * added labels to ICER legends
hopefully for the last time
* removed linewidth from ggplot version * fixed plotly version * changed default legend positioning to play nice with plotly
* added native plotly contour function * fixed bug where ggplot legend position could not be modified
* added contour2 plotly option * moved plotly contour lines to specialized function * moved prep delta_ce (long format BCEA object) to specialized function
Wrong argument passed as graph type
Thanks, @andbe! Can you please check the problems with the checks (see above)? I think the NOTEs are fine --- I have just added the file Thanks! |
Had tested but yes, there are some errors thrown in here and there. Reverted to the previous commit and reopening this. Thanks |
I went through it again and cannot see the errors likely due to my work laptop configuration... I get a I will try with my personal pc - sorry about it! |
No worries and thank you for this! Let me know if I can do anything at my end! |