Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full plotly support and fixed bugs with ggplot2 plots #58

Merged
merged 17 commits into from
Jan 8, 2024

Conversation

andbe
Copy link
Contributor

@andbe andbe commented Jan 8, 2024

  • ceplane ggplot and plotly fixes
  • added ceef plotly
  • ceac ggplot and plotly fixes
  • added contour, contour2 plotly
  • fixed contour, contour2 ggplot
  • added bcea.plot plotly
  • added CEriskav plotly

andbe added 17 commits December 5, 2023 11:16
* fixed issue with ICERs not plottable with plotly
* fixed issue with points cloud not resizable with plotly
* added comparison label to ICER points with plotly
* fixed issue with legend positions in corners (eg topleft) with ggplot
* added different default values in prep_ceplane_params with plotly, passing the graph parameter to the function
* fixed bug in "right" legend positioning
* added labels to ICER legends
hopefully for the last time
* removed linewidth from ggplot version
* fixed plotly version
* changed default legend positioning to play nice with plotly
* added native plotly contour function
* fixed bug where ggplot legend position could not be modified
* added contour2 plotly option
* moved plotly contour lines to specialized function
* moved prep delta_ce (long format BCEA object) to specialized function
Wrong argument passed as graph type
@giabaio
Copy link
Owner

giabaio commented Jan 8, 2024

Thanks, @andbe! Can you please check the problems with the checks (see above)? I think the NOTEs are fine --- I have just added the file CITATION.cff (which is specific to GitHub, I think) to .Rbuildignore, so that would go away. There are a bunch of other errors, though (to do with things like no visible global function definition or no vising binding), here and there... We're trying to keep this repo as clean as possible so that when we're ready with all the changes we can submit to CRAN with minimal overhead...

Thanks!

@giabaio giabaio merged commit 79d4732 into giabaio:dev Jan 8, 2024
0 of 6 checks passed
@giabaio
Copy link
Owner

giabaio commented Jan 8, 2024

Had tested but yes, there are some errors thrown in here and there. Reverted to the previous commit and reopening this.

Thanks

@andbe
Copy link
Contributor Author

andbe commented Jan 22, 2024

I went through it again and cannot see the errors likely due to my work laptop configuration... I get a SSL connect error - cannot open the connection to 'http://cran.rstudio.com//web/packages/packages.rds' Execution halted
but I still see 0 errors, 0 warnings and 0 notes so that's... misleading at best.

I will try with my personal pc - sorry about it!

@giabaio
Copy link
Owner

giabaio commented Jan 22, 2024

No worries and thank you for this! Let me know if I can do anything at my end!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants