Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix plot #59

Merged
merged 3 commits into from
Jan 25, 2024
Merged

bug fix plot #59

merged 3 commits into from
Jan 25, 2024

Conversation

n8thangreen
Copy link
Contributor

No description provided.

@n8thangreen
man-roxygen to md format
cf858b1
@n8thangreen
bugfix
60bea9c 
* line width in ceac plot. ggplot changed in v3 to linewidth from size argument and had only changed some of the code. updated to scale_linewidth_manual()
@giabaio
Copy link
Owner

giabaio commented Jan 25, 2024

@n8thangreen did you include @andbe's changes too (for the plotly stuff?). I get a bunch of failures for the various R-CMD-checks --- they're not the end of the world and we're pushing to the dev branch too. But eventually we'll have to sort these out?...

@n8thangreen
fixed bug in unit tests
cbce0fa 
* replaced with load(test_path("testdata", "ce.RData"))
@n8thangreen
Copy link
Contributor Author

I think I've fixed the errors at my end; I'd moved the test data to its own folder and hadn't updated all of the code.
I haven't checked all of Andrea's changes. I think it would make sense to send me a PR (ideally from a branch) so I can see all the changes. I'll drop him a message...

@giabaio giabaio merged commit 6edcff0 into giabaio:dev Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n8thangreen @giabaio