Skip to content

bug fix plot#59

Merged
giabaio merged 3 commits intogiabaio:devfrom
n8thangreen:dev
Jan 25, 2024
Merged

bug fix plot#59
giabaio merged 3 commits intogiabaio:devfrom
n8thangreen:dev

Conversation

@n8thangreen
Copy link
Contributor

No description provided.

* line width in ceac plot. ggplot changed in v3 to linewidth from size argument and had only changed some of the code. updated to scale_linewidth_manual()
@giabaio
Copy link
Owner

giabaio commented Jan 25, 2024

@n8thangreen did you include @andbe's changes too (for the plotly stuff?). I get a bunch of failures for the various R-CMD-checks --- they're not the end of the world and we're pushing to the dev branch too. But eventually we'll have to sort these out?...

* replaced with load(test_path("testdata", "ce.RData"))
@n8thangreen
Copy link
Contributor Author

I think I've fixed the errors at my end; I'd moved the test data to its own folder and hadn't updated all of the code.
I haven't checked all of Andrea's changes. I think it would make sense to send me a PR (ideally from a branch) so I can see all the changes. I'll drop him a message...

@giabaio giabaio merged commit 6edcff0 into giabaio:dev Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants