Call GetExtended[Tcp|Udp]Table twice under free-threaded build #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid using global state for the size of the allocated tcp/udp table, we fall back to the slower path of calling the `GetExtended[Tcp|Udp]Table` APIs twice, once to get the size of the table we need to allocate, and once to actually populate the table. Signed-off-by: Lysandros Nikolaou <[email protected]>
lysnikolaou
force-pushed
the
g_tcptablesize-global-state
branch
from
d8bf3d4 to
94a84d0
Compare
|
Friendly ping for a review here as well if you ever find some time. |
|
@giampaolo Sorry for the repetitive pings, but getting this over the finish-line would make testing a bit easier for me, whenever you get some time. |
|
@giampaolo Is there anything I can do to help push this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
To avoid using global state for the size of the allocated tcp/udp table, we fall back to the slower path of calling the
GetExtended[Tcp|Udp]TableAPIs twice, once to get the size of the table we need to allocate, and once to actually populate the table. Related to #2565.