-
Notifications
You must be signed in to change notification settings - Fork 2
Cloudflare R2 #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cloudflare R2 #88
Conversation
…ject lifecycle rule: - Delete uploaded objects after 30 days (for free users)
|
An error occured. This error may be due to rate limits. If this error persists, please email us. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gianpaj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a significant infrastructure change by transitioning the application's audio file storage from Vercel Blob to Cloudflare R2. This migration primarily affects the audio generation API, which now leverages R2 for storage and introduces a mechanism to organize generated audio based on user subscription tiers.
Highlights
- Storage Migration to Cloudflare R2: The core change in this pull request is the migration of audio file storage from Vercel Blob to Cloudflare R2. This involves updating configuration, documentation, and the API logic to interact with R2.
- R2 Integration for Audio Generation: The
/api/generate-voice
route has been refactored to use Cloudflare R2 for storing generated audio files. A new utility function (uploadFileToR2
) is introduced to handle the upload process. - Tiered Storage for Users: The system now differentiates storage paths for generated audio based on a user's paid status. Paid users' audio is stored in a dedicated folder, while free users' audio goes into a separate 'free' folder.
- Documentation and Configuration Updates: All relevant documentation files (
.env.example
,ARCHITECTURE.md
,CLAUDE.md
,README.md
) have been updated to reflect the switch to Cloudflare R2 and its required environment variables. Thenext.config.js
file was also updated to allow the new R2 domain in the Content Security Policy.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates audio file storage from Vercel Blob to Cloudflare R2 for the /generate-audio
route, updating environment variables, documentation, and file upload logic to use the AWS S3 SDK with R2. A critical issue exists in the WAV file generation that could lead to corrupted files, and a high severity issue exists in the new R2 upload utility function.
const buffer = Buffer.from(rawData, 'base64'); | ||
const wavHeader = createWavHeader(rawData.length, options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The createWavHeader
function is being called with rawData.length
. rawData
is a base64 encoded string, so its length is not the correct byte length of the decoded audio data. This will result in a WAV file with an incorrect header, specifically the Subchunk2Size
will be wrong, which can cause playback issues or file corruption.
The length of the decoded Buffer
should be used instead. The commented-out line contains the correct implementation.
const wavHeader = createWavHeader(rawData.length, options); | |
const wavHeader = createWavHeader(buffer.length, options); |
contentType: string, | ||
) => { | ||
const params: PutObjectCommandInput = { | ||
Bucket: process.env.R2_BUCKET_NAME, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The R2_BUCKET_NAME
environment variable is used without a non-null assertion (!
). This is inconsistent with how other environment variables are accessed in this file (e.g., R2_ACCESS_KEY_ID!
). If R2_BUCKET_NAME
is not set in the environment, Bucket
will be undefined
, causing a runtime error when the S3 command is sent. To prevent this and maintain consistency, a non-null assertion should be added.
Bucket: process.env.R2_BUCKET_NAME, | |
Bucket: process.env.R2_BUCKET_NAME!, |
Bug Report
Comments? Email us. This is the last day of your free trial. Subscribe at jazzberry.ai. |
An error occured. This error may be due to rate limits. If this error persists, please email us. |
/generate-audio
route/clone-voice
routeupdate
next.config.js
-remotePatterns
@vercel/blob
packagescripts/sync-with-redis.js
filelater
app/[lang]/page.tsx