Skip to content

Cloudflare R2 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Cloudflare R2 #88

wants to merge 6 commits into from

Conversation

gianpaj
Copy link
Owner

@gianpaj gianpaj commented Jul 6, 2025

  • /generate-audio route
  • /clone-voice route

update

  • next.config.js - remotePatterns
  • remove @vercel/blob package
  • update or remove scripts/sync-with-redis.js file

later

  • upload sample files to R2 and update app/[lang]/page.tsx

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

jazzberry-ai bot commented Jul 6, 2025

An error occured.

This error may be due to rate limits. If this error persists, please email us.

Copy link

vercel bot commented Jul 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sexyvoice ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2025 5:42pm

Copy link

socket-security bot commented Jul 6, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​aws-sdk/​client-s3@​3.842.09810010097100

View full report

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gianpaj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant infrastructure change by transitioning the application's audio file storage from Vercel Blob to Cloudflare R2. This migration primarily affects the audio generation API, which now leverages R2 for storage and introduces a mechanism to organize generated audio based on user subscription tiers.

Highlights

  • Storage Migration to Cloudflare R2: The core change in this pull request is the migration of audio file storage from Vercel Blob to Cloudflare R2. This involves updating configuration, documentation, and the API logic to interact with R2.
  • R2 Integration for Audio Generation: The /api/generate-voice route has been refactored to use Cloudflare R2 for storing generated audio files. A new utility function (uploadFileToR2) is introduced to handle the upload process.
  • Tiered Storage for Users: The system now differentiates storage paths for generated audio based on a user's paid status. Paid users' audio is stored in a dedicated folder, while free users' audio goes into a separate 'free' folder.
  • Documentation and Configuration Updates: All relevant documentation files (.env.example, ARCHITECTURE.md, CLAUDE.md, README.md) have been updated to reflect the switch to Cloudflare R2 and its required environment variables. The next.config.js file was also updated to allow the new R2 domain in the Content Security Policy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates audio file storage from Vercel Blob to Cloudflare R2 for the /generate-audio route, updating environment variables, documentation, and file upload logic to use the AWS S3 SDK with R2. A critical issue exists in the WAV file generation that could lead to corrupted files, and a high severity issue exists in the new R2 upload utility function.

const buffer = Buffer.from(rawData, 'base64');
const wavHeader = createWavHeader(rawData.length, options);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The createWavHeader function is being called with rawData.length. rawData is a base64 encoded string, so its length is not the correct byte length of the decoded audio data. This will result in a WAV file with an incorrect header, specifically the Subchunk2Size will be wrong, which can cause playback issues or file corruption.

The length of the decoded Buffer should be used instead. The commented-out line contains the correct implementation.

Suggested change
const wavHeader = createWavHeader(rawData.length, options);
const wavHeader = createWavHeader(buffer.length, options);

contentType: string,
) => {
const params: PutObjectCommandInput = {
Bucket: process.env.R2_BUCKET_NAME,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The R2_BUCKET_NAME environment variable is used without a non-null assertion (!). This is inconsistent with how other environment variables are accessed in this file (e.g., R2_ACCESS_KEY_ID!). If R2_BUCKET_NAME is not set in the environment, Bucket will be undefined, causing a runtime error when the S3 command is sent. To prevent this and maintain consistency, a non-null assertion should be added.

Suggested change
Bucket: process.env.R2_BUCKET_NAME,
Bucket: process.env.R2_BUCKET_NAME!,

Copy link

jazzberry-ai bot commented Jul 6, 2025

Bug Report

Name Severity Example test case Description
Inconsistent User Paid Status due to Redis Cache Invalidation Medium A user subscribes to a paid plan, but the Redis cache is not updated promptly. The user attempts to generate a voice and gets incorrectly identified as a free user, leading to audio stored in the wrong folder. The checkUserPaidStatus relies on Redis for subscription status. Delays/failures in webhook updates can lead to stale data, causing paid users to be treated as free users or vice versa.
Hardcoded CDN URL in uploadFileToR2 High Deploy the app with a custom domain for the R2 bucket. Generate audio. The generated URL will still point to https://files.sexyvoice.ai/${filename}, ignoring the custom domain. The uploadFileToR2 hardcodes the CDN URL, preventing the use of custom domains for serving audio. This can lead to CDN issues, SSL errors, or access restrictions.
Lack of Specific Error Handling for R2 Uploads Low Misconfigure R2 credentials. Generate audio. A generic error is returned ("Failed to generate voice"). Sentry captures the exception, but lacks R2-specific details (e.g., "Invalid access key"). The uploadFileToR2 lacks specific error handling. R2 upload failures result in generic error messages, making debugging difficult.

Comments? Email us. This is the last day of your free trial. Subscribe at jazzberry.ai.

Copy link

jazzberry-ai bot commented Jul 6, 2025

An error occured.

This error may be due to rate limits. If this error persists, please email us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant