Improve ClusterAutoscalerFailedScaling alert to reduce false positives #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| runbook_url: https://intranet.giantswarm.io/docs/support-and-ops/ops-recipes/cluster-autoscaler-scaling/ | ||
| expr: cluster_autoscaler_failed_scale_ups_total{provider=~"capa|capz|eks"} > 0 | ||
| for: 15m | ||
| expr: increase(cluster_autoscaler_failed_scale_ups_total{provider=~"capa|capz|eks"}[15m]) > 3 and rate(cluster_autoscaler_failed_scale_ups_total{provider=~"capa|capz|eks"}[5m]) > 0 |
There was a problem hiding this comment.
These values aren't right I don't think. We had a legit issue that this alert should have caught with cicdprod on the 27th but this doesn't catch it.
There was a problem hiding this comment.
Ok thanks I'll investigate
There was a problem hiding this comment.
Also I think we can drop that provider label. Not sure why we'd need that. We only have autoscaler on CAPA anyway
There was a problem hiding this comment.
It might be changing it to > 1 would fire it properly WDYT?
There was a problem hiding this comment.
Yeah but I think you'll then need to drop the for and just have it trigger as soon as it goes over the value
There was a problem hiding this comment.
Yeah removed for, dropped the provider and adjusted the increase
Gacko
approved these changes
Jun 6, 2025
AverageMarcus
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: https://github.com/giantswarm/giantswarm/issues/33440
This PR improves the
ClusterAutoscalerFailedScalingalert to reduce false positives by combining two expressions: