Skip to content

PrometheusOperatorRejectedResources: only page for MC resources #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

hervenicol
Copy link
Contributor

Towards https://github.com/giantswarm/giantswarm/issues/33820
This PR changes the behaviour of the PrometheusOperatorRejectedResources alert so it only pages for resources running on the management clusters.

Checklist

@hervenicol hervenicol self-assigned this Jul 3, 2025
@hervenicol hervenicol requested a review from a team as a code owner July 3, 2025 12:00
@QuentinBisson
Copy link
Contributor

Did we not agree to remove this alert? Also, I have no clue what a luster_type is but it might be NSFW :D

@hervenicol hervenicol force-pushed the update-prometheusoperator branch from f245c6c to aa28c64 Compare July 3, 2025 12:46
@hervenicol
Copy link
Contributor Author

Yes, I saw and fixed the luster_id typo 😅
We discussed in the alerts session we wanted this alert to keep paging for MCs.
The reason is on MCs we still run some resources that are validated by prometheus-operator. IIRC mainly prometheus-rules.

@hervenicol hervenicol merged commit 3b3b5d1 into main Jul 3, 2025
6 checks passed
@hervenicol hervenicol deleted the update-prometheusoperator branch July 3, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants