Add pin validation #175
Open
Add pin validation #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
we try to keep the changes to the core files to a minimum (pin config as an exception) is it possible to rewrite the change to not change the core files? next to that, can you remove the .gitignore from the pull request? |
Author
Unfortunately I don't know if we can mix the two solution for setting up the pin and also it is not using the same function to interact with the pins. About the changelog do you prefer a second PR? or no .gitignore at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake while configuring this component with the pin. The mistake was obvious and could have been avoid if the pin selection was using the ESPHome pin representation that checks the pin for the selected board. This PR does replace the int representation of a pin with a stronger type from ESPHome.
I added a .gitinore file and VSCode did fix some formatting issues.