Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing code #31

Open
SlamCabbage opened this issue Aug 1, 2023 · 0 comments
Open

missing code #31

SlamCabbage opened this issue Aug 1, 2023 · 0 comments

Comments

@SlamCabbage
Copy link

void performSCLoopClosure()
{
if (cloudKeyPoses3D->points.empty() == true)
return;
// find keys
auto detectResult = scManager.detectLoopClosureID(); // first: nn index, second: yaw diff
int loopKeyCur = copy_cloudKeyPoses3D->size() - 1;;
int loopKeyPre = detectResult.first;
float yawDiffRad = detectResult.second; // not use for v1 (because pcl icp withi initial somthing wrong...)
if( loopKeyPre == -1 /* No loop found */)
return;

Missing assignments to copy_cloudKeyPoses6D, copy_cloudKeyPoses2D, and copy_cloudKeyPoses3D lead to errors at runtime.

In the previous code is:

        mtx.lock();
        *copy_cloudKeyPoses3D = *cloudKeyPoses3D;
        copy_cloudKeyPoses2D->clear();            // giseop
        *copy_cloudKeyPoses2D = *cloudKeyPoses3D; // giseop
        *copy_cloudKeyPoses6D = *cloudKeyPoses6D;
        mtx.unlock();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant