Merged
Conversation
MSYS2 renamed the directory. Move our files to a matching directory in preparation for the update to version 18.1.6 Signed-off-by: Matthias Aßhauer <[email protected]>
rimrul
force-pushed
the
mingw-w64-clang-18.1.2
branch
from
b1155ef to
9bc59bd
Compare
Member
Author
|
Needs git-for-windows/gfw-helper-github-app#81 before we can |
Member
Author
|
/deploy The workflow run was started. |
We need to be careful not to replace any trailing space and backslash when replacing the value of LLVM_TARGETS_TO_BUILD. MSYS2 also renamed the directory, so pkgname needs to be adapted slightly. Signed-off-by: Matthias Aßhauer <[email protected]>
Signed-off-by: Matthias Aßhauer <[email protected]>
rimrul
force-pushed
the
mingw-w64-clang-18.1.2
branch
from
9bc59bd to
062f600
Compare
rimrul
commented
Jun 3, 2024
| -e 's/-DCMAKE_BUILD_TYPE=Release/-DCMAKE_BUILD_TYPE=MinSizeRel/' \ | ||
| -e 's/-DLLVM_TARGETS_TO_BUILD=[^)]*/-DLLVM_TARGETS_TO_BUILD=Native/' \ | ||
| -e 's/-DLLVM_TARGETS_TO_BUILD=[^)\\]*/-DLLVM_TARGETS_TO_BUILD=Native/' \ | ||
| -e 's/-DLLVM_TARGETS_TO_BUILD=Native\\/-DLLVM_TARGETS_TO_BUILD=Native \\/' \ |
Member
Author
There was a problem hiding this comment.
I've thought about [^)\\ ] instead of removing and reintroducing a potential space, but decided against it to not have this break again due to a random space in a future target list.
Member
Author
|
/deploy The workflow run was started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes git-for-windows/git#4874