Switch from Asciidoctor extensions to regular Asciidoctor#84
Merged
dscho merged 1 commit intogit-for-windows:mainfrom Jun 17, 2024
Merged
Switch from Asciidoctor extensions to regular Asciidoctor#84dscho merged 1 commit intogit-for-windows:mainfrom
dscho merged 1 commit intogit-for-windows:mainfrom
Conversation
In git-for-windows/MINGW-packages#119, Git for Windows switched away from the custom-built Asciidoctor extensions, now instead using the regular Asciidoctor. This patch is a companion of that PR to ensure that Git for Windows' SDK is aligned with that change. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
git-sdk-64-github-workflows
branch
from
2e8c58b to
385936c
Compare
rimrul
approved these changes
Jun 16, 2024
dennisameling
approved these changes
Jun 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
mingw-w64-asciidoctor-extensionspackage as well as theasciidoctorgem are uninstalled, and that themingw-w64-asciidoctorpackage is installed instead. This PR is a companion of git-for-windows/MINGW-packages#119.Here is a run (with one commit on top to trigger said run) that verifies that it does what I intend.