Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe fix 5839 #5841

Merged
merged 3 commits into from
Jan 2, 2025
Merged

maybe fix 5839 #5841

merged 3 commits into from
Jan 2, 2025

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented Dec 16, 2024

This PR makes a few changes to assure the shell is also used on Windows when invoking gpg.

That way, more of the typical environment may be picked up, which hopefully affects #5839 positively.

The strange thing is that there it worked before without a shell as well, and since on Windows it did manual argument splitting, ultimately it would make the same command-call like before, calling a pure gpg binary without shell involvement.

So chances are that besides unifying the operation on all platforms by using a shell, it might still not work as expected.

Maybe there are other changes that affect #5839 between v0.14.3 and v0.14.4?

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 2:25pm

Copy link

vercel bot commented Dec 16, 2024

@Byron is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Dec 16, 2024
@Byron Byron marked this pull request as ready for review December 16, 2024 07:27
@Byron Byron requested a review from ndom91 December 16, 2024 07:28
@mtsgrd
Copy link
Contributor

mtsgrd commented Jan 2, 2025

@ndom91 is there any way to configure an allowlist user filter for the vercel integration?

@ndom91
Copy link
Contributor

ndom91 commented Jan 2, 2025

@ndom91 is there any way to configure an allowlist user filter for the vercel integration?

You mean like to run the actions on forked PRs? Not that I know of. There is a global switch to allow them to run on PRs from forked repos of users who aren't a part of the Vercel team though

@Byron
Copy link
Collaborator Author

Byron commented Jan 2, 2025

Let's merge this, I think it will do what it should on Windows and it's a chance it will work better than before as Windows will also run it through a shell then, just like it does on Unix. Maybe that helps it pick up more of the environment it needs.

@Byron Byron merged commit 9c8f9f1 into gitbutlerapp:master Jan 2, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants