-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maybe fix 5839 #5841
maybe fix 5839 #5841
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
gitbutlerapp#5839) That way, the shell will be used on Windows as well.
@ndom91 is there any way to configure an allowlist user filter for the vercel integration? |
You mean like to run the actions on forked PRs? Not that I know of. There is a global switch to allow them to run on PRs from forked repos of users who aren't a part of the Vercel team though |
Let's merge this, I think it will do what it should on Windows and it's a chance it will work better than before as Windows will also run it through a shell then, just like it does on Unix. Maybe that helps it pick up more of the environment it needs. |
This PR makes a few changes to assure the shell is also used on Windows when invoking
gpg
.That way, more of the typical environment may be picked up, which hopefully affects #5839 positively.
The strange thing is that there it worked before without a shell as well, and since on Windows it did manual argument splitting, ultimately it would make the same command-call like before, calling a pure
gpg
binary without shell involvement.So chances are that besides unifying the operation on all platforms by using a shell, it might still not work as expected.
Maybe there are other changes that affect #5839 between v0.14.3 and v0.14.4?