Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing license info in Cargo.toml files #354

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Mar 17, 2025

To avoid ambiguity in terms of licensing, explicitly provide a license parameters in the Cargo.toml of all packages in the repository. This should also help FOSSA, which currently struggles to determine the license for these crates.

The license is set to Apache-2.0, as for the packages that already stated a license.

Relates to #332

To avoid ambiguity in terms of licensing, explicitly provide a license
parameters in the Cargo.toml of all packages in the repository. This
should also help FOSSA, which currently struggles to determine the
license for these crates.

The license is set to Apache-2.0, as for the packages that already
stated a license.

Also mark the dataplane-id crate as non-publishable, for consistency
with the other packages.

Signed-off-by: Quentin Monnet <[email protected]>
@qmonnet qmonnet requested a review from a team as a code owner March 17, 2025 13:37

This comment was marked as off-topic.

@daniel-noland
Copy link
Collaborator

This is very strange. I swear I already did this but I clearly did not.

Good catch. Approved

Copy link
Collaborator

@daniel-noland daniel-noland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qmonnet qmonnet added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 6f49b31 Mar 17, 2025
16 checks passed
@qmonnet qmonnet deleted the pr/qmonnet/packages-licenses branch March 17, 2025 21:11
Copy link
Contributor

@mvachhar mvachhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants